Subject: Discussion related to cado-nfs
List archive
- From: Seth Troisi <braintwo@gmail.com>
- To: cado-nfs-discuss@lists.gforge.inria.fr
- Subject: [Cado-nfs-discuss] [Patch] Fix mksol ETA bug
- Date: Sun, 12 Jan 2020 23:57:15 -0800
- Authentication-results: mail3-smtp-sop.national.inria.fr; spf=None smtp.pra=braintwo@gmail.com; spf=Pass smtp.mailfrom=braintwo@gmail.com; spf=None smtp.helo=postmaster@mail-oi1-f174.google.com
- Ironport-phdr: 9a23:Aq+QUBQYz0lzRYbJODxavWKaSdpsv+yvbD5Q0YIujvd0So/mwa69YByN2/xhgRfzUJnB7Loc0qyK6vumAzJRqs/Y7jgrS99lb1c9k8IYnggtUoauKHbQC7rUVRE8B9lIT1R//nu2YgB/Ecf6YEDO8DXptWZBUhrwOhBoKevrB4Xck9q41/yo+53Ufg5EmCexbal9IRmrowjdrNcajIpmJ6o+1xfFv3pFcPlKyG11Il6egwzy7dqq8p559CRQtfMh98peXqj/Yq81U79WAik4Pm4s/MHkugXNQgWJ5nsHT2UZiQFIDBTf7BH7RZj+rC33vfdg1SaAPM32Sbc0WSm+76puVRTlhjsLOyI//WrKjMF7kaBVrw+7pxFnzIHaYI+bOvljcK3DYdwXXm9BUtpLWiFbHo+wc4kCAuwcNuhYtYn9oF4OoAOjCwayGOPvyiJDiGHs3a090uQhCgDG1xEnEt0VqnTbttT1NKEOUeG7y6nF1jrDb/ZM1jf87IjEaAwuofaJXb9pd8fa1EohFxvdg1mOtYDoOymZ2+cNvmSB8uZtVOCih3Q6pwxzrTWiwNonhJPTiYIP0F/E8D10wIYrKt28T052edukH4FRtyGeLod2RcIiT3xxtCY017ELu5G2cDIFyJQgwB7fZPiHfJaS7h3/U+aRJC90hHNjeL2hmxa/6VasxvH4W8Wu01tHrjBJnsTNu30PzRDf98qKR/Rl8kekwzmP1gTT6u9eIUAzkKrWM4UuwqQqmZoSt0TDAiH3mELtga+Zc0Ur4Omo6+D9brr6oZ+cMpd4ihviPaQ2hsy/HeM4PxASUGeB5Ou806Tv/Uv3QLVRl/E5j6jZsIvGKsQGva65GBRY0oIi6xakEzemy84UnXYJLFJCYhKHgJbmN0vPIPD+F/e/gk6jnC1lx/DcbfXdBcDGJ3TE1bHvZvNx6lVX1REo5dRe/I5PTL4PJ+j8VwnwssbZB1k3KV+a2eHiXe5wyoNWZXiIA7SYePfYq1aJ4P4wJMGDYYYUvHD2LP1ztK2mtmMwhVJIJfrh5pAQcn3tRq03cXXcWmLlh5I6KUlPuwM/SOLwj1jbCGxcYn+zW+Q34TRpUdv6X7eGfZikhfm65An+BodfPzkUBVWFEHOufIKBCa9VNXCiZ/R5mzlBboCPDo8s0Rb06l3/wrtja+3Vo2gW7M2/ktdy4OLXmFc58jkmV8k=
- List-archive: <http://lists.gforge.inria.fr/pipermail/cado-nfs-discuss/>
- List-id: A discussion list for Cado-NFS <cado-nfs-discuss.lists.gforge.inria.fr>
mksol eta has a bug where it doesn't increment iter (and s/iter increases linearly each print)
It's as simple
- timing_disp_collective_oneline(pi, timing, bw->start + sx - s0, tcan_print, "mksol");
+ timing_disp_collective_oneline(pi, timing, bw->start + sx, tcan_print, "mksol");
+ timing_disp_collective_oneline(pi, timing, bw->start + sx, tcan_print, "mksol");
Old
Info:Linear Algebra: krylov: N=100 ; ETA (N=800): Sun Jan 12 23:49:31 2020 [0.006 s/iter]
Info:Linear Algebra: krylov: N=200 ; ETA (N=800): Sun Jan 12 23:49:31 2020 [0.006 s/iter]
...
Info:Linear Algebra: krylov: N=200 ; ETA (N=800): Sun Jan 12 23:49:31 2020 [0.006 s/iter]
...
Info:Linear Algebra: krylov: N=800 ; ETA (N=800): Sun Jan 12 23:49:30 2020 [0.004 s/iter]
Info:Linear Algebra: lingen ETA: Sun Jan 12 23:49:30 2020
Info:Linear Algebra: mksol: N=100 ; ETA (N=400): Sun Jan 12 23:49:32 2020 [0.002 s/iter]
Info:Linear Algebra: mksol: N=100 ; ETA (N=400): Sun Jan 12 23:49:33 2020 [0.004 s/iter]
Info:Linear Algebra: mksol: N=100 ; ETA (N=400): Sun Jan 12 23:49:33 2020 [0.005 s/iter]
Info:Linear Algebra: mksol: N=87 ; ETA (N=400): Sun Jan 12 23:49:34 2020 [0.008 s/iter]
Info:Linear Algebra: lingen ETA: Sun Jan 12 23:49:30 2020
Info:Linear Algebra: mksol: N=100 ; ETA (N=400): Sun Jan 12 23:49:32 2020 [0.002 s/iter]
Info:Linear Algebra: mksol: N=100 ; ETA (N=400): Sun Jan 12 23:49:33 2020 [0.004 s/iter]
Info:Linear Algebra: mksol: N=100 ; ETA (N=400): Sun Jan 12 23:49:33 2020 [0.005 s/iter]
Info:Linear Algebra: mksol: N=87 ; ETA (N=400): Sun Jan 12 23:49:34 2020 [0.008 s/iter]
New
Info:Linear Algebra: krylov: N=100 ; ETA (N=800): Sun Jan 12 23:49:58 2020 [0.005 s/iter]
Info:Linear Algebra: krylov: N=800 ; ETA (N=800): Sun Jan 12 23:49:58 2020 [0.003 s/iter]
Info:Linear Algebra: lingen ETA: Sun Jan 12 23:49:58 2020
Info:Linear Algebra: mksol: N=100 ; ETA (N=400): Sun Jan 12 23:49:59 2020 [0.002 s/iter]
Info:Linear Algebra: mksol: N=200 ; ETA (N=400): Sun Jan 12 23:49:59 2020 [0.002 s/iter]
Info:Linear Algebra: mksol: N=300 ; ETA (N=400): Sun Jan 12 23:49:59 2020 [0.002 s/iter]
Info:Linear Algebra: mksol: N=386 ; ETA (N=400): Sun Jan 12 23:49:59 2020 [0.002 s/iter]
Info:Linear Algebra: krylov: N=800 ; ETA (N=800): Sun Jan 12 23:49:58 2020 [0.003 s/iter]
Info:Linear Algebra: lingen ETA: Sun Jan 12 23:49:58 2020
Info:Linear Algebra: mksol: N=100 ; ETA (N=400): Sun Jan 12 23:49:59 2020 [0.002 s/iter]
Info:Linear Algebra: mksol: N=200 ; ETA (N=400): Sun Jan 12 23:49:59 2020 [0.002 s/iter]
Info:Linear Algebra: mksol: N=300 ; ETA (N=400): Sun Jan 12 23:49:59 2020 [0.002 s/iter]
Info:Linear Algebra: mksol: N=386 ; ETA (N=400): Sun Jan 12 23:49:59 2020 [0.002 s/iter]
From 90933711e2d232ad43efd5da6e980ef9096ad11c Mon Sep 17 00:00:00 2001
From: Seth Troisi <sethtroisi@google.com>
Date: Sun, 12 Jan 2020 23:56:06 -0800
Subject: [PATCH] fix mksol ETA
---
linalg/bwc/mksol.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linalg/bwc/mksol.cpp b/linalg/bwc/mksol.cpp
index bf161cc40..50b3f7cd9 100644
--- a/linalg/bwc/mksol.cpp
+++ b/linalg/bwc/mksol.cpp
@@ -468,7 +468,7 @@ void * mksol_prog(parallelizing_info_ptr pi, param_list pl, void * arg MAYBE_UNU
serialize(pi->m);
// reached s + bw->interval. Count our time on cpu, and compute the sum.
- timing_disp_collective_oneline(pi, timing, bw->start + sx - s0, tcan_print, "mksol");
+ timing_disp_collective_oneline(pi, timing, bw->start + sx, tcan_print, "mksol");
}
mmt_vec_untwist(mmt, ymy[0]);
--
2.17.1
- [Cado-nfs-discuss] [Patch] Fix mksol ETA bug, Seth Troisi, 01/13/2020
- Re: [Cado-nfs-discuss] [Patch] Fix mksol ETA bug, paul zimmermann, 01/13/2020
Archive powered by MHonArc 2.6.19+.