Subject: Discussion related to cado-nfs
List archive
- From: Emmanuel Thomé <Emmanuel.Thome@inria.fr>
- To: Simon Wells <swel024@gmail.com>
- Cc: cado-nfs@inria.fr
- Subject: Re: [cado-nfs] [PATCH] ignore fmt
- Date: Tue, 14 Jan 2025 08:41:50 +0100
- Authentication-results: mail3-smtp-sop.national.inria.fr; spf=None smtp.pra=Emmanuel.Thome@inria.fr; spf=Pass smtp.mailfrom=emmanuel.thome@elliptic.org; spf=None smtp.helo=postmaster@mail-lf1-f48.google.com
- Ironport-data: A9a23:K2SnI6Og1jBGisHvrR1dk8FynXyQoLVcMsEvi/4bfWQNrUp20WEAn TdOC2+Pb/qPYmGgfNp/aoyz8UxTvsCAy4NkSXM5pCpnJ55ogZqcVI7Bdi8cHAvLc5adFBo/h yk6QoOdRCzhZiaE/n9BCpC48T8mk/vgqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziLBVOSvU0 T/Ji5OZYQXNNwJcaDpOtvra8U835ZwehRtB1rAATaAT1LPhvyJNZH4vDfnZB2f1RIBSAtm7S 47rpF1u1j6xE78FU7tJo56jGqE4aua60Tum1hK6b5Ofbi1q/UTe5EqU2M00Mi+7gx3R9zx4J U4kWZaYEW/FNYWU8AgRvoUx/4iT8sSq9ZeeSUVTv/B/wGXcfHL3ndQpM3oTFp8korZPUG4Q5 7sXfWVlghCr34pawZq+Q+how8AtdYzlYNNZtXZnwjXUS/0hRPgvQY2QvY4ejGp2354RW6qOD yYaQWIHgBDobhhKM1EKBZZ4gOevg3TXfjlcqUqJpKFx5HLcpOB0+OG1boCLJIbVHK25mG6mj FLIo2reBCpCav+11Quvq3uNv93AyHaTtIU6T+DhrqE73jV/3Fc7AxQaUh69r+KRkV+7Q9sZK koO+yNoo7JayaCwZtz0Xhn9pHDd+xBAC5xfFOo17AzLwa3Ri+qEOoQaZiROYcd4lYgJfhkBx GPRz+u4CmJ997LAHBpx6YyohT+1PCEUK0oLaikFURYJ7rHfTGcb3kKnojFLQP7dszHlJQwc1 Qxmu8TXuln+pcsC1qH++V6exjzw9t7GSQk64giRVWWghu+YWGJHT932gbQ4xa8fRGp8crVnl CZe8yR5xL5XZaxhbATXHI0w8EiBvp5pygH0j191BIUG/D+w4XOldo04yGghfxk2Y51cKGSwP he7VeZtCHl7bCvCgUhfM9LZNijW5fK4fTgYfqmLPooQPcIpHON51H4zNRHKt4wSrKTcufpiY M/EIJjE4YcyBqNgwz67D+Yb2vlD+8zN7TK7eHwP9Dz+ieD2TCfNF98taQLSBshntv/siFuOq L53aZDaoyizpcWkPkE7B6ZJcAhSdRDWxPne96RqSwJ0ClE8SDh8W6SLn+hJlk4Mt/09q9okN 0qVAidwoGcTT1WdQelTQiEzNuHcTtxkoGglPCchG1+t1jJxKcys9aoTPd9/N7Uu6OUpn7Y+Q ugnavewJK1Fag3G3DABMrj7johpLyqwiSy0YiGKXTkYfrxbfTLvxOPKRAXU2RM1PnKFjvdm+ 7yE/SHHcKUHXDVnXZr3aurw7lafvko9ueNVXmnQKN9xYHTXrY1hKg3qr/oNO8pXAw7y9jib8 Ae3ABkjuujGpbEuwuTJnaypq4SIEfN0OEhRD033zOyTG3HB32yBxYRgbr65TQrFXjmpxJT4N PRn8f7sFdYmwnBIitNYOJR2x/sc49DPmedr/j58Fi+WU2XxW6JSGVjY78xhraYX+6R4vzGxU Uex+tV3H7WFFcfmMVwJLjoeceWx+qAIqwbW8MgKDh321A1v8JqDdHdiDR2GpSheDblyaacO4 +MqvuwI4A2e1DsuFPu7jR5vymfdFUxYDp0btawbDrT71Sst6FVJOqLHBgHMvZqgVtRrM2sRG AGyupbsvbpm+xf9QyIBLkSVhet5rrYSiS9O124HdgiomMKap/oZ3y9x0DUQTyZRxDpXy+lTA HBaJhBrLqCF/hNDpstKb0azES5vWTyb/U3QzQMStWv7FkOHaE3EHFcfC82son8L0jh5UGBA3 be6zG3Fb27bTPvp1HFvZX8/+u3Rc9Nh0ybjxualJp2hNLsna2PHhqSOWzI5myH/C5lsuHyd9 PhYx8cuW6jVLiVKnrYaDbOd3rEuSBypAmxObPVi3aERF1HnZzCA9mmSGn+1Z/9yCaTGwW2gB +xqA/B/ZRC0+SKNjzIcXIonAbt/mtw379sjJJLvA0M7sIWkkzk4i6KIqxDCh1IqTe5+zuc7C IfaLAyZHkKq2HB7pm7qret/AFSeX+UqXgPH8d6QzPQoDLMG6eFlTlEz2OC7vlKTKwpWwCiXt wLiOY7Tluxr9ptwlaTdAoF8Nl2TAo71Xr7Z9gqcjsl/N4LTEMbRtjE6rkvsEBRWMIAwBfV2t +Wpm/zm0HzVuI0ZVzjipKCAMK1S9+CebfFxMMnnCFV7xAysANTN5TkH8ECGca15qstXvJSbd lHpefmOes4wcPYD4n9sMgx1MQsXUobzZYfe/RKNleyGUEUh4FaWPeGc1CHbaE9AfXU1ILz4M Aj/vsiu6v1+rIhhABwlBelsM6RnIW3MCLcXSNnsiQa2VmWYoEuOmr/HpyoS7TvmDnqlEsGjx bnnQhP4Vgq5uYCW7dV/nrFxgCYqDydGsbFtRn4ext94tWnrRipOZ+EQKo4PBZxogzT/nsOwL i3EaGw5Tz7xR3JYeBH7+87uRRqbGvdIANriOzg15AmBXk9a3m9b7GdJrU+MIkuaewcPCMmiI NAav3n+Z12/nsEvSuEU6fi2x+xgw5s2A57OFV/Vy6TP79Q2WN3mF0CN2CJAUSjGC93MnwPMP 2ddqaVsXhSgUUCoeSp/Uyc9Jfza1Q8DCx0paz2OyZDRoe13CQGGJOLXY4nO71HIUCjGyHPii 586q6thLl16AkAuhJY=
- Ironport-hdrordr: A9a23:VrmblKgepktCB79JFHIBaM6PIXBQXiwji2hC6mlwRA09TyVXrb HQoB17726LtN9/YgBYpTntAtjnfZqYz+8T3WBzB8bGYOCFghrTEGgK1+KLqF2QeBEWtNQtsZ uIG5IeNDSaNykGsS+V2njFL/8QhPeCtI+ljfrD1Ht2JDsaEJ1I3kNWDkK0HCRNKDWuxqBVKL OsouRCrzqkPVINbsq6AXEBG8zOvcfCmp6jQTNuPW9e1OBNt1mVAXLBfCRwFy1xIlFy/Ys=
- Ironport-phdr: A9a23:YMFvkBOfO4lCiT5Ygv4l6nZQBBdPi9zP1u491JMrhvp0f7i5+Ny6Z QqDvqwr1QKUFtyDtLptsKn/jePJYS863d65qncMcZhBBVcuqP49uEgeOvODElDxN/XwbiY3T 4xoXV5h+GynYwAOQJ6tL1LdrWev4jEMBx7xKRR6JvjvGo7Vks+7y/2+94fcbghGmTaxe65+I RW2oAneq8UanYlvIbstxxXUpXdFZ+tZyWR0KFyJmBry+tm+94N5/SRKvPIh+c9AUaHkcKk9U LdVEjcoPX0r6cPyrRXMQheB6XUaUmUNjxpHGBPF4w3gXpfwqST1qOxw0zSHMMLsTLA0XTOi7 7p3SBLtlSwKOSI1/H3Rh8dtl69Qvg6vqAJjzI7VeIGVNeRxfqXBfdMBWGFNWt9dWzFdDo+ga ocCCfcKM+RFoInnv1YBohW+CgusCu3hyTFGm2H40LMm3Ok6Cw7KwBYtEsgSvHjIrtj4MroZX +CvzKnPyDXOd/xY2TL46IfSdBAhvO+DXbZtesTPyUkvEAbFiU+NooHiMD2V0+ENvHKd7+p9S +2vj3QrpR9xojiow8cjlJLEhoMTylDe9CV22pw5JdOiSENiZ9OvDZRfuT2AOYRsXsMiX39nu Dw8yrAepJO2eCYHxpomyhDQZPKKfYaG7xPnWeuTPTt1i3ZodrK/ihuy8EWuxfHxW9Sp3VtIr CdIk8TAu20C2hHT9sWKV/1w9Vqv1zaI0gDc8OBEIUYsmKrUKp4h3r4wlocIvkjZAiD2n0D2g amLfUsn4uil8/rrbqniq5OGNIJ5ihvyPrkvl8G9G+g1PQsDU3CF9eig0LDv5070TbVQgvEoj qXUs4rWKdkZq6O6BQJez5gu6xKiDze9zNQXg2MHIk9EeBOGkYfkI03CLfblBvmlmVusii1kx /XeM73hHJrNKn/Dna/kfbln6k5czBM/zdRR555JE70BLv3+V0zruNzXCR85NAO0w+L5B9lny oweXmePDreYMKPUr1CI+voiL/eQaIIRojrwKPgo6+TzgXI4m1IRZ6ak0JgPZHC9BPtmIkGZY XT2gtcGFGcHphQxTOnviFKYVz5Temi9X6Ym6jEnCIKmCoLDSZ62jbOf2Ce7GpxWZnhaClCND XjkbYKEW+0DaC6KJM9uiSQLVaK9RI85yRGuqAj6xqJ6IubM4C0XqYrj1MRp5+3UjRw96SZ7A Nma022USWF0kHgISiQt3KF/pEx90k2M3bJ5g/xeD9xT5ulGXh00NZ7GnKRGDIXJWwfGeJ+2R VKiWZ3yGi48Soprn/cBZk98H5OpiRWVjASwBLpAurmODZop/6aU43j2Ikc1n1vD0aAnklQiB PdPMmirrq957QnaQYDTxRbK3522fLgRiXaevFyIynCD6QQBCFYYucTtWHkeYhCTttHl/gbZS KfoD707MwxHwMrEK61Qa9Svg08VDOz7NoH4ZGS803y1GQ7O3qmFOafvfmwbwSjZTnQElAUe1 XeALwk3QCm78CrFFDI7LVv0eAv39PVm7nayT0s61QaPOkBk0rOz5xMRw+CcTPYe9r8AvCY5t zR/WlGn0IGeEMKO8ixmeqgUetYh+BFH2Gbe4hR6JYClJrt+i0Q2dg12uwbq2UwyBNkQ18ctq 3wuwUx5LqfwPEppUTSe0NiwP7TWLjK35xWzc+vN3UmY1t+K+6AJ4fB+qlP5vQjvGFBwu3Ngm 8JY1XeR/PCoREIbTI7xX0Ar9hN7u6CSYy8z4JnR3GFtNq/8uyHL2tYgDu8oghi6eNIXPKSBH Q70W8oUYqrmYMEvnlGvcx8AetxS86s5F8KgbfqPnqCxfa5hkD+gkWVb8dVlyEvfkkg0AuXM3 psD37SZxl7dD2a63Arn656o39wUNlRwViKlxCPpBZBcfPh3dIcPUiK1JtGvg855n9jrUmJZ8 1iqAxUH3tWocFycdQ+Yv0UY2EIJrHiggSb9wSZzlmRjo6+a1SrTzuCkaBoAP2NjSW1mjE/wI IPyiMoVFhvNDUBhhF6+6ED2yrIO7ol6KmDVXEpMORT2KGRveqq2rLuLJcBVosBN020fQKG3Z laUTaT4qh0R3nb4HmdQ8zs8cimjppTzmxESZHu1FH9otzKZfMhxwUya/9nAXbtK2SJAQiBki D7RD1z6Pt+z/NzSmY2R+uy5UmugUNVUf0yJhcuNsS6y43BnBVujn/e2l/XqFQw7yTP63J9tT yqAoBvnY4bt3ri3Kqo9JhguVAK6spQlXN0u2oIr4fNYkWAXnJCU4WYKnS/oPNNX1Li/JHsBS DgXwsLEtQ3s2UltNHWMlMryUnSQxNckZsHvODtHnHJgqZkUV+HIvO8h/2M9uFezoAPPbOIom z4czaBr83sGm6QSvxJryCyBA7cUFE0ePCr2lh3O4crtyccfLGupb7W001Jz2N67C7TX6AxZX X//Z5omWzNw6cByGF/I1Hzr9oDvPt7KYphA03/c2weFlOVTJJ8rw7AHgC9uP3/wuTs5y+k+g DRj2ZW7pJSGICNq5q3zUXs6fnXlIsgU/D/ql6NXmM2bipuuEptWETIORJL0TPisHWFapbH9O g2JCjF5tmaDFO+VA1qE8Ek/5SGqcdjjJzSNKXIe19knWBSNOBkVnlUPRDtj1p8hSlLxmYq4I R8/vGxOoAa/8EcEy/o0ZUejFD2E/0HxNG9yEN/GfX80pklD/xuHb5LYt7opWXkeptr79ESMM jDJOVoOVz1YHBzcQQikZOHm5MGcobfCQLPiaaKfO/PW7rUOMpXAjZO3jtk5o3DVbJjJZj86S KRlkktbASIgQ5SfwmpQDXxRz2WXNoaavEvuo3Is6JnurLKzHlqovNXqafMaMM0zqUru0OHTa qjJ3nY/cXEBidsN3SOakuFBmgNCzXg/LX/1Vu1R/S/VEPCKw/ERVUVKLXgpcpMPtvNZvEEFL 8ffjpmdOqdQqPkzBh8FUFXgnprsfskWOySmM0uBAk+XNbOALDmNwsftYKr6R6cCxONT/wa9v zqWCSqBdnyKiiXpWhazMOpNkDDTPRpQv5u4ewpsDm6rRczvaxmyOtt6xTMsxrh8inTPPG8ae T9yFiEF5qWX9j9di+5jFnZp63NkKayAlX/c4bWIbJkRtvRvD2J/kOcbqHU2xr1J7T1VEfx4n CyBy7wm61qik+SJ1n9mSE8U8mcN1N/N5Bs9f/mJpfwiET7e8RkA7HudEUEPrtphUZj0vrxIj 8PIjOT1IStD9NTd+Y0dAdLVIYSJKilEU1KhFTjKAQ8CVTPuO3vYghkXnfSX/3uIo5x8tpjrn ZcmR7tfVUQpF/hcDV5qVo9nQt8/TnY/nLiXgdRdr2K5twXUTd5Gs4rvU/uTBbDrJm/cg+UUI RQPxrz8IMIYMYixiCkAIhFq2Y/NHUTXR9VEpCZsOxQ1rEt6+397VmQv2kjhZ2tFD1ceEfq1h gI3gU15e+t/rV8EAn8yL1vO4S8+yQw/xYWjjjeWfzr8aqy3WNMOY8IRn0k3KJLyBQhvP1Xao A==
- Ironport-sdr: 6786154b_Ongc1py3x97IP5OnSKwkqWo/Y/5/s5DLak6JVXp8gq+DAbu 0vltfD6Vtfj0WFs5USvkXDEVKtbBxYHlNrn4a3g==
Hi,
Could you provide a little bit more context?
fmt (https://github.com/fmtlib/fmt) is an external library, of which we embed a snapshot for convenience. Its include files are consistently found under the fmt/ subdirectory (whether we're talking of our embedded snapshot or if it's installed system-wide), which makes a lot of sense given that include names such as "os.h", "core.h" or "base.h" are so common that we don't want them to mess up with other possible includes.
I can see absolutely no reason for dropping the fmt/ prefix in includes.
E.
On Tue, Jan 14, 2025 at 7:53 AM Simon Wells <swel024@gmail.com> wrote:
---
utils/embedded/fmt/os.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utils/embedded/fmt/os.cc b/utils/embedded/fmt/os.cc
index 102000be8..fed349b8a 100644
--- a/utils/embedded/fmt/os.cc
+++ b/utils/embedded/fmt/os.cc
@@ -10,7 +10,7 @@
# define _CRT_SECURE_NO_WARNINGS
#endif
-#include "fmt/os.h"
+#include "os.h"
#ifndef FMT_MODULE
# include <climits>
--
2.39.5
- [cado-nfs] [PATCH] ignore fmt, Simon Wells, 01/14/2025
- Re: [cado-nfs] [PATCH] ignore fmt, Emmanuel Thomé, 01/14/2025
Archive powered by MHonArc 2.6.19+.