CGAL users discussion list

["Wang, Kai" <>]

Hi all,

 

I'm sorry if the following has already been discussed.

 

It seems that there exists a bug in the file subdivision_mask_3.h, in class Linear_mask_3, method void border_node(Halfedge_handle edge, Point& ept, Point& vpt) (from line 109).

 

This method does not modify the value of the variable vpt, which is passed by reference. Meanwhile, when calling this method from the file Subdivision_method_impl_3.h using mask.border_node(eitr, edge_point_buffer[i], vertex_point_buffer[v]) at lines 107 and 226, the elements in vertex_point_buffer seem not having been initialized as the initial vertex point values in the current mesh. So, when I used this linear mask, I could have meaningless subdivision results (e.g. infinite values) on borders.

 

Should the method void border_node(…) in subdivision_mask_3.h be something like the following?
void border_node(Halfedge_handle edge, Point& ept, Point& vpt){
 edge_node(edge, ept);

 

 Point vp0 = edge->vertex()->point();
 vpt = Point(vp0[0], vp0[1], vp0[2]);

}

 

Best regards,

 

Kai

2009.05.11

 

_____________________________________
Wang, Kai
Ph.D. Student in Computer Science
LIRIS, INSA-Lyon, France
Tel: (+33)-4 72 43 60 97
E-mail:
URL: http://liris.cnrs.fr/kai.wang