CGAL users discussion list

[Armando Duarte <>]

    Hi there,
    
    The code below within
    
    #if CGAL_VERSION_NR < 1041401000
    
    
    #else
    
    compiles and have worked for years with CGAL 4.13.2 or older. It
    does not, however, compile with CGAL 4.14 or later (see error
    message below). Release notes 
    https://www.cgal.org/2019/03/29/cgal414/
    does not mention a breaking change related to aabb trees.
    Is there a way to make this code compile or an implementation based
    on the code below within
    
    #else
    
    #end
    
    must be used with CGAL 4.14 or later?
    I.e, do we have to use boost::graph_traits< HalfedgeGraph
    >::edge_iterator after CGAL 4.14 with the aabb tree defined
    below?
    
    Thank you!
    
    Armando Duarte
    
    // Adapted from CGAL Manual
    #include <iostream>
    #include <vector>
    #include <boost/graph/graph_traits.hpp>
    
    //#include <CGAL/Simple_cartesian.h>
    #include <CGAL/Exact_predicates_exact_constructions_kernel.h>
    #include <CGAL/AABB_tree.h>
    #include <CGAL/AABB_traits.h>
    #include <CGAL/Polyhedron_3.h>
    #include <CGAL/AABB_halfedge_graph_segment_primitive.h>
    
    //typedef CGAL::Simple_cartesian<double> K;
    typedef CGAL::Exact_predicates_exact_constructions_kernel    K;
    typedef K::FT FT;
    typedef K::Point_3 Point;
    typedef K::Triangle_3 Triangle;
    
    typedef CGAL::Polyhedron_3<K> Polyhedron;
    
    typedef CGAL::AABB_halfedge_graph_segment_primitive<Polyhedron,
    /*VertexPointPMap*/ CGAL::Default,
                                                        /*
    OneHalfedgeGraphPerTree*/ CGAL::Tag_true > Primitive;
    typedef CGAL::AABB_traits<K, Primitive> Traits;
    typedef CGAL::AABB_tree<Traits> Tree;
    
    template <class Kernel, class HalfedgeGraph>
    void run(HalfedgeGraph& graph){
      typename Kernel::Point_3 p(1.0, 0.0, 0.0);
      typename Kernel::Point_3 q(0.0, 1.0, 0.0);
      typename Kernel::Point_3 r(0.0, 0.0, 1.0);
    
      // constructs the AABB tree with hedges of a Polyhedron_3
      Tree tree;
    
      std::cout << "\nInserting subset of edges using vector
    iterators" << std::endl;
    
      //#if 1 
     #if CGAL_VERSION_NR < 1041401000
    
      // This compiles and have worked for years with CGAL 4.13.2 or
    older. It does not compile with CGAL 4.14 or later.
      // Release notes  https://www.cgal.org/2019/03/29/cgal414/
      // does not mention a *breaking change* related to aabb trees.
      // How to make this code compile? (see error message below).
      
      std::cout << "\nCGAL_VERSION < 4.14 adopted" <<
    std::endl;
    
      // Store a couple of hedges from HalfedgeGraph graph into vector
    with hedges
      typename std::vector< typename HalfedgeGraph::Halfedge_handle
    > my_hedges;
      
      typename HalfedgeGraph::Edge_iterator edge_pos =
    graph.edges_begin();
      
      my_hedges.push_back( &(*edge_pos) );
      
      edge_pos++;
      my_hedges.push_back( &(*edge_pos) );
    
      // Get a hedge stored in vector my_edges.
      typename std::vector< typename HalfedgeGraph::Halfedge_handle
    >::iterator hedge_pos = my_hedges.begin();
      ++hedge_pos;
      typename HalfedgeGraph::Halfedge_handle my_halfedge_handle =
    (*hedge_pos);
        
      std::cout << "\nmy_halfedge_handle point = " <<
    my_halfedge_handle->vertex()->point();
      std::cout << "\nhd_hedge_opposite point = " <<
    my_halfedge_handle->opposite()->vertex()->point() <<
    std::endl;
    
      // Rebuild aabb tree with HalfedgeGraph::Halfedge_handle stored in
    vector my_edges
      tree.rebuild( my_hedges.begin(), my_hedges.end(), graph );
      
    #else
    
      // This compiles with CGAL 4.14 or later buy it will require lots
    of code changes.
      
      std::cout << "\nCGAL_VERSION >= 4.14 adopted" <<
    std::endl;
    
      // Is there an easier way to insert a subset of Halfedges of a
    CGAL:Polyhedron_3 in a CGAL:AABB_tree?
      // Do we have to use boost::graph_traits< HalfedgeGraph
    >::edge_iterator after CGAL 4.14?
    
      // vector to store edges we want to use with AABB tree.
      // Type used comes from CGAL header
    AABB_halfedge_graph_segment_primitive.h
      std::vector< typename boost::graph_traits< HalfedgeGraph
    >::edge_descriptor > my_edges;
    
      // Use this to pick edges from HalfedgeGraph graph
      typename boost::graph_traits< HalfedgeGraph >::edge_iterator
    epos_start = CGAL::edges(graph).first;
    
      typename boost::graph_traits< HalfedgeGraph
    >::edge_descriptor edge = *epos_start;
      my_edges.push_back( edge );
    
      epos_start++;
      edge = *epos_start;
      my_edges.push_back( edge );
    
      // Return one of the halfedges corresponding to edge
      //
https://doc.cgal.org/latest/BGL/classHalfedgeGraph.html#aa6d5e0b5380b5b80bbc2ed90e3e707f7
      typename boost::graph_traits< HalfedgeGraph
    >::halfedge_descriptor hedge_descritor = halfedge(edge, graph);
      // Covert the halfedge_descriptor into a Halfedge_handle
      typename HalfedgeGraph::Halfedge_handle my_halfedge_handle;
      my_halfedge_handle = (hedge_descritor);
    
      typename HalfedgeGraph::Halfedge_handle hd_hedge_opposite =
    my_halfedge_handle->opposite();
    
      std::cout << "\nmy_halfedge_handle point = " <<
    my_halfedge_handle->vertex()->point();
      std::cout << "\nhd_hedge_opposite point = " <<
    hd_hedge_opposite->vertex()->point() << std::endl;
      
      
      // Type of first two arguments to this method are iterators
      // boost::graph_traits< EdgeListGraph >::edge_iterator
      // Their value is boost::graph_traits< HalfedgeGraph
    >::edge_descriptor
      // Rebuild aabb tree with boost::graph_traits< HalfedgeGraph
    >::edge_descriptor stored in vector
      tree.rebuild( my_edges.begin(), my_edges.end(),
                    graph);
    
    #endif
       
      // counts #intersections with a triangle query
      Triangle triangle_query(p,q,r);
      std::cout <<
    tree.number_of_intersected_primitives(triangle_query)
          << " intersections(s) with triangle" << std::endl;
      //  assert( tree.number_of_intersected_primitives(triangle_query
    )== 6);
      // computes the closest point from a query point
      typename Kernel::Point_3 point_query(2.0, 2.0, 2.0);
      typename Kernel::Point_3 closest =
    tree.closest_point(point_query);
      std::cerr << "closest point is: " << closest <<
    std::endl;  
    }
    int main()
    {
      Point p(1.0, 0.0, 0.0);
      Point q(0.0, 1.0, 0.0);
      Point r(0.0, 0.0, 1.0);
      Point s(0.0, 0.0, 0.0);
      Polyhedron polyhedron;
      polyhedron.make_tetrahedron(p, q, r, s);
      
      run<K>(polyhedron);
      return EXIT_SUCCESS;
    }
    
    /*
    Error message if using CGAL 4.14 or later and the first version of
    the code:
    
    [ 66%] Building CXX object
projects/helperprograms/test_AABB_tree/CMakeFiles/test_AABB_tree_3_to_post.dir/test_AABB_tree_3_to_post.C.o
    In file included from
/Users/armando/SetSolver_git/SetSolver/projects/helperprograms/test_AABB_tree/test_AABB_tree_3_to_post.C:11:
/Users/armando/SetSolver_hg/CGAL-4.14.3/include/CGAL/AABB_halfedge_graph_segment_primitive.h:181:17:
    error: no matching member function for call to 'make_id'
        : Base( Id_(make_id(*it, graph, OneHalfedgeGraphPerTree())),
                    ^~~~~~~
/Users/armando/SetSolver_hg/CGAL-4.14.3/include/CGAL/AABB_tree.h:774:27:
    note: in instantiation of function template specialization
'CGAL::AABB_halfedge_graph_segment_primitive<CGAL::Polyhedron_3<CGAL::Epeck>>::AABB_halfedge_graph_segment_primitive<std::__wrap_iter<CGAL::internal::In_place_list_iterator<CGAL::HalfedgeDS_in_place_list_halfedge<CGAL::I_Polyhedron_halfedge<CGAL::HalfedgeDS_halfedge_base<CGAL::HalfedgeDS_list_types<CGAL::Epeck,
    CGAL::I_Polyhedron_derived_items_3<CGAL::Polyhedron_items_3>,
    std::allocator<int>>>>>,
std::allocator<CGAL::HalfedgeDS_in_place_list_halfedge<CGAL::I_Polyhedron_halfedge<CGAL::HalfedgeDS_halfedge_base<CGAL::HalfedgeDS_list_types<CGAL::Epeck,
    CGAL::I_Polyhedron_derived_items_3<CGAL::Polyhedron_items_3>,
    std::allocator<int>>>>>>> *>>'
    requested here
                           
    m_primitives.push_back(Primitive(first,std::forward<T>(t)...));
                                                   ^
/Users/armando/SetSolver_hg/CGAL-4.14.3/include/CGAL/AABB_tree.h:791:5:
    note: in instantiation of function template specialization
    'CGAL::AABB_tree<CGAL::AABB_traits<CGAL::Epeck,
CGAL::AABB_halfedge_graph_segment_primitive<CGAL::Polyhedron_3<CGAL::Epeck>>>>::insert<std::__wrap_iter<CGAL::internal::In_place_list_iterator<CGAL::HalfedgeDS_in_place_list_halfedge<CGAL::I_Polyhedron_halfedge<CGAL::HalfedgeDS_halfedge_base<CGAL::HalfedgeDS_list_types<CGAL::Epeck,
    CGAL::I_Polyhedron_derived_items_3<CGAL::Polyhedron_items_3>,
    std::allocator<int>>>>>,
std::allocator<CGAL::HalfedgeDS_in_place_list_halfedge<CGAL::I_Polyhedron_halfedge<CGAL::HalfedgeDS_halfedge_base<CGAL::HalfedgeDS_list_types<CGAL::Epeck,
    CGAL::I_Polyhedron_derived_items_3<CGAL::Polyhedron_items_3>,
    std::allocator<int>>>>>>> *>,
    CGAL::Polyhedron_3<CGAL::Epeck> &>' requested here
        insert(first, beyond,std::forward<T>(t)...);
        ^
/Users/armando/SetSolver_git/SetSolver/projects/helperprograms/test_AABB_tree/test_AABB_tree_3_to_post.C:66:8:
    note: in instantiation of function template specialization
    'CGAL::AABB_tree<CGAL::AABB_traits<CGAL::Epeck,
CGAL::AABB_halfedge_graph_segment_primitive<CGAL::Polyhedron_3<CGAL::Epeck>>>>::rebuild<std::__wrap_iter<CGAL::internal::In_place_list_iterator<CGAL::HalfedgeDS_in_place_list_halfedge<CGAL::I_Polyhedron_halfedge<CGAL::HalfedgeDS_halfedge_base<CGAL::HalfedgeDS_list_types<CGAL::Epeck,
    CGAL::I_Polyhedron_derived_items_3<CGAL::Polyhedron_items_3>,
    std::allocator<int>>>>>,
std::allocator<CGAL::HalfedgeDS_in_place_list_halfedge<CGAL::I_Polyhedron_halfedge<CGAL::HalfedgeDS_halfedge_base<CGAL::HalfedgeDS_list_types<CGAL::Epeck,
    CGAL::I_Polyhedron_derived_items_3<CGAL::Polyhedron_items_3>,
    std::allocator<int>>>>>>> *>,
    CGAL::Polyhedron_3<CGAL::Epeck> &>' requested here
      tree.rebuild( my_hedges.begin(), my_hedges.end(), graph );
           ^
/Users/armando/SetSolver_git/SetSolver/projects/helperprograms/test_AABB_tree/test_AABB_tree_3_to_post.C:132:3:
    note: in instantiation of function template specialization
    'run<CGAL::Epeck, CGAL::Polyhedron_3<CGAL::Epeck>>'
    requested here
      run<K>(polyhedron);
      ^
/Users/armando/SetSolver_hg/CGAL-4.14.3/include/CGAL/AABB_halfedge_graph_segment_primitive.h:112:6:
    note: candidate function not viable: no known conversion from
'CGAL::internal::In_place_list_iterator<CGAL::HalfedgeDS_in_place_list_halfedge<CGAL::I_Polyhedron_halfedge<CGAL::HalfedgeDS_halfedge_base<CGAL::HalfedgeDS_list_types<CGAL::Epeck,
    CGAL::I_Polyhedron_derived_items_3<CGAL::Polyhedron_items_3>,
    std::allocator<int>>>>>,
std::allocator<CGAL::HalfedgeDS_in_place_list_halfedge<CGAL::I_Polyhedron_halfedge<CGAL::HalfedgeDS_halfedge_base<CGAL::HalfedgeDS_list_types<CGAL::Epeck,
    CGAL::I_Polyhedron_derived_items_3<CGAL::Polyhedron_items_3>,
    std::allocator<int>>>>>>>' to
'CGAL::AABB_halfedge_graph_segment_primitive<CGAL::Polyhedron_3<CGAL::Epeck>>::ED'
    (aka
'HDS_edge<In_place_list_iterator<CGAL::HalfedgeDS_in_place_list_halfedge<CGAL::I_Polyhedron_halfedge<CGAL::HalfedgeDS_halfedge_base<CGAL::HalfedgeDS_list_types<CGAL::Epeck,
    CGAL::I_Polyhedron_derived_items_3<CGAL::Polyhedron_items_3>,
    std::allocator<int>>>>>,
std::allocator<CGAL::HalfedgeDS_in_place_list_halfedge<CGAL::I_Polyhedron_halfedge<CGAL::HalfedgeDS_halfedge_base<CGAL::HalfedgeDS_list_types<CGAL::Epeck,
    CGAL::I_Polyhedron_derived_items_3<CGAL::Polyhedron_items_3>,
    std::allocator<int>>>>>>>>') for 1st
    argument
      ED make_id(ED ed, const HalfedgeGraph&, Tag_true)
         ^
/Users/armando/SetSolver_hg/CGAL-4.14.3/include/CGAL/AABB_halfedge_graph_segment_primitive.h:117:39:
    note: candidate function not viable: no known conversion from
'CGAL::internal::In_place_list_iterator<CGAL::HalfedgeDS_in_place_list_halfedge<CGAL::I_Polyhedron_halfedge<CGAL::HalfedgeDS_halfedge_base<CGAL::HalfedgeDS_list_types<CGAL::Epeck,
    CGAL::I_Polyhedron_derived_items_3<CGAL::Polyhedron_items_3>,
    std::allocator<int>>>>>,
std::allocator<CGAL::HalfedgeDS_in_place_list_halfedge<CGAL::I_Polyhedron_halfedge<CGAL::HalfedgeDS_halfedge_base<CGAL::HalfedgeDS_list_types<CGAL::Epeck,
    CGAL::I_Polyhedron_derived_items_3<CGAL::Polyhedron_items_3>,
    std::allocator<int>>>>>>>' to
'CGAL::AABB_halfedge_graph_segment_primitive<CGAL::Polyhedron_3<CGAL::Epeck>>::ED'
    (aka
'HDS_edge<In_place_list_iterator<CGAL::HalfedgeDS_in_place_list_halfedge<CGAL::I_Polyhedron_halfedge<CGAL::HalfedgeDS_halfedge_base<CGAL::HalfedgeDS_list_types<CGAL::Epeck,
    CGAL::I_Polyhedron_derived_items_3<CGAL::Polyhedron_items_3>,
    std::allocator<int>>>>>,
std::allocator<CGAL::HalfedgeDS_in_place_list_halfedge<CGAL::I_Polyhedron_halfedge<CGAL::HalfedgeDS_halfedge_base<CGAL::HalfedgeDS_list_types<CGAL::Epeck,
    CGAL::I_Polyhedron_derived_items_3<CGAL::Polyhedron_items_3>,
    std::allocator<int>>>>>>>>') for 1st
    argument
      std::pair<ED, const HalfedgeGraph*> make_id(ED ed, const
    HalfedgeGraph& fg, Tag_false)
                                          ^
    1 error generated.
    make[2]: ***
[projects/helperprograms/test_AABB_tree/CMakeFiles/test_AABB_tree_3_to_post.dir/test_AABB_tree_3_to_post.C.o]
    Error 1
    make[1]: ***
[projects/helperprograms/test_AABB_tree/CMakeFiles/test_AABB_tree_3_to_post.dir/all]
    Error 2
    make: *** [all] Error 2
    
     */

--


C. Armando Duarte, Ph.D.
Nathan Newmark Distinguished Professor

Dept. Civil and Environmental Engin.
2118 Newmark Laboratory MC 250
University of Illinois at Urbana-Champaign
205 North Mathews Av.
Urbana, Illinois 61801 USA
http://gfem.cee.illinois.edu/

https://www.youtube.com/channel/UC6wlfOnwRTYD0Tb_rfDTbTA