Re: [Starpu-devel] 2 small patches

[Samuel Thibault <samuel.thibault@inria.fr>]

Hello,

SYLVAND, Guillaume, on Tue 12 Jul 2016 09:14:46 +0000, wrote:
> Let me know if the format of these files is not adequate ;-)

The format of the files is good, thanks :)
I have just fixed some coding style before commiting.

>  char *_starpu_mpi_get_mpi_code(int code)
>  {
> +     char * r;
>       switch (code)
>       {
>       case MPI_SUCCESS: return "MPI_SUCCESS";
> @@ -210,6 +211,9 @@ char *_starpu_mpi_get_mpi_code(int code)
>  #if defined(MPI_ERR_LASTCODE) && MPI_ERR_LASTCODE != MPI_SUCCESS
>       case MPI_ERR_LASTCODE: return "MPI_ERR_LASTCODE";
>  #endif
> -     default: return "UNKNOWN_MPI_CODE";
> +     default:
> +             r = malloc(12);
> +             snprintf(r, 12, "%d", code);
> +             return r;

I preferred to use a static buffer.

Thanks!
Samuel