Subject: CGAL users discussion list
List archive
Re: [cgal-discuss] Bug in Polyhedron_incremental_builder_3::test_facet_indices()
Chronological Thread
- From: "Sebastien Loriot (GeometryFactory)" <>
- To:
- Subject: Re: [cgal-discuss] Bug in Polyhedron_incremental_builder_3::test_facet_indices()
- Date: Thu, 23 Jan 2014 09:01:49 +0100
- Organization: GeometryFactory
Hi Marius,
Thanks for the report. It should indeed be k<i. I'll fix it for the next release.
By curiosity how did you find the bug because the manifold edge test
coming after is failing on the tests I did.
Sebastien.
On 01/23/2014 06:12 AM, Marius Kintel wrote:
Hi,
Polyhedron_incremental_builder_3::test_facet_indices() tries to detect if a
list of indices has the same index specified twice.
Due to a bug, this test doesn’t actually detect that in all cases:
e.g., sending the vector [6,6,5,6] will pass this test while it should
obviously fail.
The problem appears to be on line 752:
for ( std::size_t k = 0; k+1 < i; ++k) {
..where k is being iterated one step too short to detect this issue.
-Marius
- [cgal-discuss] Bug in Polyhedron_incremental_builder_3::test_facet_indices(), Marius Kintel, 01/23/2014
- Re: [cgal-discuss] Bug in Polyhedron_incremental_builder_3::test_facet_indices(), Sebastien Loriot (GeometryFactory), 01/23/2014
- Re: [cgal-discuss] Bug in Polyhedron_incremental_builder_3::test_facet_indices(), Marius Kintel, 01/23/2014
- Re: [cgal-discuss] Bug in Polyhedron_incremental_builder_3::test_facet_indices(), Sebastien Loriot (GeometryFactory), 01/24/2014
- Re: [cgal-discuss] Bug in Polyhedron_incremental_builder_3::test_facet_indices(), Marius Kintel, 01/23/2014
- Re: [cgal-discuss] Bug in Polyhedron_incremental_builder_3::test_facet_indices(), Sebastien Loriot (GeometryFactory), 01/23/2014
Archive powered by MHonArc 2.6.18.