CGAL users discussion list

[Jeffrey Bush <>]

I am currently moving from CGAL 4.2 to 4.4. I was happy to see that many
problems I mentioned in
http://cgal-discuss.949826.n4.nabble.com/CGAL-demos-on-Windows-won-t-configure-td4656618.html#a4656639
were fixed over this time, however there were still 2 compile errors that
were fixable with changing CGAL code. I have found fixes to one of the
(including one which was a long-time mystery to the CGAL folks and repeated
many times on these boards).

In addition to these fixes there was a bug in Eigen v.3.2.1 that I have
reported to them causing all imports of SparseTransformation.h to cause an
internal compiler error. With the fixes below and the ones to Eigen I do not
get any compiler errors (just warnings about int/int64 conversions,
float/double conversions, bool conversions, and MSVCRT incompatibility
warnings with TAUCS).

Fixes:

demo\Polyhedron\CMakeLists.txt@252:
-     target_link_libraries( Polyhedron_3 QtScriptTools )

It doesn't work since the library name is either QtScriptToolsd4 or
QtScriptTools4 (on Windows). Additionally, the subsequent
target_link_libraries( Polyhedron_3 ${QT_LIBRARIES} ) includes the right
QtScriptTools so it is superfluous (on Windows at least).


include\CGAL\Kinetic\Delaunay_triangulation_3.h@90-91:
-    typedef internal::Delaunay_3_edge_flip_event<This_DT3, Root_stack>
Edge_flip;
-    typedef typename internal::Delaunay_3_facet_flip_event<This_DT3,
Root_stack> Facet_flip;
+    typedef internal::Delaunay_3_edge_flip_event<This_DT3, typename
TraitsT::Kinetic_kernel::Side_of_oriented_sphere_3::result_type> Edge_flip;
+    typedef typename internal::Delaunay_3_facet_flip_event<This_DT3,
typename TraitsT::Kinetic_kernel::Side_of_oriented_sphere_3::result_type>
Facet_flip;

This caused the error in Delaunay_triangulation_base_3.h that many people
have complained about. Apparently in the definition here, the Root_stack was
picking up some other random Root_stack and not the one defined shortly
above it. Fix was to use the explicit type instead of Root_stack. There are
probably more condensed versions of it that work, but this one was the first
I tried and it worked so I stuck with it. It *should* work fine in other
compilers too.

Thanks!
Jeff



--
View this message in context: 
http://cgal-discuss.949826.n4.nabble.com/Some-CGAL-4-4-Bug-Fixes-tp4659159.html
Sent from the cgal-discuss mailing list archive at Nabble.com.