cgal-discuss - [cgal-discuss] Triangulation_3.h uses deprecated std::random_shuffle

Subject: CGAL users discussion list

List archive

[cgal-discuss] Triangulation_3.h uses deprecated std::random_shuffle

From: Adam Getchell <>
To:
Subject: [cgal-discuss] Triangulation_3.h uses deprecated std::random_shuffle
Date: Fri, 30 Mar 2018 12:23:39 -0700
Authentication-results: mail2-smtp-roc.national.inria.fr; spf=None ; spf=Pass ; spf=None
Ironport-phdr: 9a23:bjzELRTPubsLEOFb4Dikp7nxLdpsv+yvbD5Q0YIujvd0So/mwa6yYheN2/xhgRfzUJnB7Loc0qyK6/umATRIyK3CmUhKSIZLWR4BhJdetC0bK+nBN3fGKuX3ZTcxBsVIWQwt1Xi6NU9IBJS2PAWK8TW94jEIBxrwKxd+KPjrFY7OlcS30P2594HObwlSizexfb1/IA+qoQnNq8IbnZZsJqEtxxXTv3BGYf5WxWRmJVKSmxbz+MK994N9/ipTpvws6ddOXb31cKokQ7NYCi8mM30u683wqRbDVwqP6WACXWgQjxFFHhLK7BD+Xpf2ryv6qu9w0zSUMMHqUbw5Xymp4qF2QxHqlSgHLSY0/mHLhcN/kaxVoxyvqQJ4zYPPeo6ZKP9+c7ndfd8GW2ZMWNtaWSxbAoO7aosCF/YMMvtCoIn4ulAArAWxBRWwC+Pv1DBIgnv21rA93us7DA7JxgkgE8gBsHvKsNX6KKcSXv6xzKnM1jjDYPZW1i386IjMaBwuvfaMXbdpfMfX1EIhGQTFjlCKpozkOTOYzuANs2yF7+plT+6vjHQnqw5prjis2MgtipLGiZgOyl/a7yl5wYE1KcW3SE56fd6kEIZQuDqAO4RqRcMiRnlktzoiyr0eo560YiYKx4o9xxHBbfyIb5aH7gj/W+aWJDd1gm9udrGnhxuq70Ss1unxWtO33VtKtCZJjMTAu3MX2xHT9MSLUuVx80m71TqSygze6ftILV03mKfVMZIt37E9mocVvE/eBCH5gl/2g7WTdkg8+uin9eDnYrL+q5+ZLYB0iwX+Pr0pmsy+Heg0KwYOUmiF9eim273j+kr5QLpOjvIoiKXWrJfaJcEDqq64BQ9azJoj5g6hAzu61NkUh3oKIVJfdB6ZkoTkOEvCLfDmAfunhlSjijZrx/TIPr37BZXNK2DOn638crln7k5Q0gUzws5D551ICrEOPvbzWkvqudzXCx82KQ20w+L9BNph0YMeXHqDArWFP6PKrV+I+uUvLvGQa48aojn9L+Ep6OPvjX8ihVAdYLKp3YAMZXCjHvVmJl2ZbmD2jtcAF2cKpAs+Q/bwhF2MSz4AL0q1Cqkz7zV+BIO9BprYXaishqaA1WG1BM54fGdDX3mAGHKgWIiYUPcBbCbadsZtmzlCWrW9QI8s0RWGuwrzyr4hJe3RrH5L/an/3cR4srWA3So58iZ5WpzEgjO9Clpsl2ZNfAcYmaV2oEhz0FCGiPEqjPlRFNgV7PRMAF5jaczsitdiAtW3YTrvO8+TQQ//ENqjCDA1CNk2xo1WOhsvK5CZlhnGmhGSLfoVmriMXsFm96vd2z32Jp44xSuckqYmiFYiT41EMmj03qM=

The std::random_shuffle was deprecated in C++14 and eliminated in C++17 in favor of std::shuffle.

http://en.cppreference.com/w/cpp/algorithm/random_shuffle

Triangulation_3.h (among many others) uses std::random_shuffle, so compilation errors occur with C++17.

https://github.com/CGAL/cgal/issues/2974

As far as I can tell, this is still true of the most recent code, e.g. 4.12-beta1.

This looks fixable with ClangTidy, e.g.

https://clang.llvm.org/extra/clang-tidy/checks/modernize-replace-random-shuffle.html

Would a pull request to apply these changes be accepted?

Thanks,

Adam

Adam Getchell
https://keybase.io/adamgetchell

[cgal-discuss] Triangulation_3.h uses deprecated std::random_shuffle, Adam Getchell, 03/30/2018

List archive

[cgal-discuss] Triangulation_3.h uses deprecated std::random_shuffle