Objet : Developers list for StarPU
Archives de la liste
- From: Samuel Thibault <samuel.thibault@ens-lyon.org>
- To: Nathalie Furmento <nathalie.furmento@labri.fr>
- Cc: starpu-devel@lists.gforge.inria.fr
- Subject: Re: [Starpu-devel] [patch request] Double comparison
- Date: Mon, 30 Jan 2012 15:15:07 +0100
- List-archive: <http://lists.gforge.inria.fr/pipermail/starpu-devel>
- List-id: "Developers list. For discussion of new features, code changes, etc." <starpu-devel.lists.gforge.inria.fr>
Nathalie Furmento, le Mon 30 Jan 2012 14:18:24 +0100, a écrit :
> > > - if (exp == -1.0 && !model->benchmarking)
> > > + if (_starpu_approximately_equal(exp, -1.0) && !model->benchmarking)
> >
> > Mmm, no, such kind of comparisons are supposed to be exact: we really
> > put exactly there -1.0 as a markup. Using such a long function name
> > makes the code way less readable. At best we could introduce
> > _starpu_is_nan, and use nan instead of -1 as marker.
> >
> > Same for all other occurrences.
>
> Can we directly use isnan() defined in <math.h> ?
Sure.
Samuel
- [Starpu-devel] [patch request] Double comparison, Nathalie Furmento, 30/01/2012
- <Suite(s) possible(s)>
- Re: [Starpu-devel] [patch request] Double comparison, Samuel Thibault, 30/01/2012
- Re: [Starpu-devel] [patch request] Double comparison, Nathalie Furmento, 30/01/2012
- Message indisponible
- Re: [Starpu-devel] [patch request] Double comparison, Samuel Thibault, 30/01/2012
- Message indisponible
- Re: [Starpu-devel] [patch request] Double comparison, Samuel Thibault, 30/01/2012
Archives gérées par MHonArc 2.6.19+.