Re: [Starpu-devel] DAG with Tag dependences

[Samuel Thibault <samuel.thibault@ens-lyon.org>]

Duchateau, Alexandre, le Tue 26 Jun 2012 17:10:22 +0200, a écrit :
> Attached is a small example (my larger cases have thousands of tasks)
> 
> Am I missing something somewhere ?

It seems the relation between tags and tasks was not implemented. You
can try the latest svn, or the attached patch.

Samuel
Index: src/debug/traces/starpu_fxt.c
===================================================================
--- src/debug/traces/starpu_fxt.c       (révision 6871)
+++ src/debug/traces/starpu_fxt.c       (révision 6872)
@@ -646,6 +646,17 @@
        fprintf(activity_file, "cnt_submitted\t%f\t%lu\n", current_timestamp, 
nsubmitted);
 }
 
+static void handle_codelet_tag(struct fxt_ev_64 *ev)
+{
+       uint64_t tag;
+       unsigned long job;
+
+       tag = ev->param[0];
+       job = ev->param[1];
+
+       _starpu_fxt_dag_add_tag(tag, job);
+}
+
 static void handle_codelet_tag_deps(struct fxt_ev_64 *ev)
 {
        uint64_t child;
@@ -920,7 +931,7 @@
                                break;
 
                        case _STARPU_FUT_TAG:
-                               /* XXX */
+                               handle_codelet_tag(&ev);
                                break;
 
                        case _STARPU_FUT_TAG_DEPS:
Index: src/debug/traces/starpu_fxt.h
===================================================================
--- src/debug/traces/starpu_fxt.h       (révision 6871)
+++ src/debug/traces/starpu_fxt.h       (révision 6872)
@@ -40,6 +40,7 @@
 
 void _starpu_fxt_dag_init(char *dag_filename);
 void _starpu_fxt_dag_terminate(void);
+void _starpu_fxt_dag_add_tag(uint64_t tag, unsigned long job_id);
 void _starpu_fxt_dag_add_tag_deps(uint64_t child, uint64_t father);
 void _starpu_fxt_dag_set_tag_done(uint64_t tag, const char *color);
 void _starpu_fxt_dag_add_task_deps(unsigned long dep_prev, unsigned long 
dep_succ);
Index: src/debug/traces/starpu_fxt_dag.c
===================================================================
--- src/debug/traces/starpu_fxt_dag.c   (révision 6871)
+++ src/debug/traces/starpu_fxt_dag.c   (révision 6872)
@@ -64,6 +64,13 @@
        fclose(out_file);
 }
 
+void _starpu_fxt_dag_add_tag(uint64_t tag, unsigned long job_id)
+{
+       if (out_file)
+               fprintf(out_file, "\t 
\"tag_%llx\"->\"task_%llx\"->\"tag_%llx\"\n",
+                       (unsigned long long)tag, (unsigned long long)job_id, 
(unsigned long long) tag);
+}
+
 void _starpu_fxt_dag_add_tag_deps(uint64_t child, uint64_t father)
 {
        if (out_file)