Accéder au contenu.
Menu Sympa

starpu-devel - [Starpu-devel] Heft/dmda: locking in compute_all_performance_predictions.

Objet : Developers list for StarPU

Archives de la liste

[Starpu-devel] Heft/dmda: locking in compute_all_performance_predictions.


Chronologique Discussions 
  • From: Cyril Roelandt <cyril.roelandt@inria.fr>
  • To: "starpu-devel@lists.gforge.inria.fr" <starpu-devel@lists.gforge.inria.fr>
  • Subject: [Starpu-devel] Heft/dmda: locking in compute_all_performance_predictions.
  • Date: Thu, 22 Nov 2012 17:22:52 +0100
  • List-archive: <http://lists.gforge.inria.fr/pipermail/starpu-devel>
  • List-id: "Developers list. For discussion of new features, code changes, etc." <starpu-devel.lists.gforge.inria.fr>

Hey !

In heft, the following code is executed in compute_all_performance_predictions():

/* Sometimes workers didn't take the tasks as early as we expected */
_STARPU_PTHREAD_MUTEX_LOCK(&sched_mutex[worker]);
fifo->exp_start = STARPU_MAX(fifo->exp_start, starpu_timing_now());
exp_end[worker][nimpl] = fifo->exp_start + fifo->exp_len;
if (exp_end[worker][nimpl] > max_exp_end)
max_exp_end = exp_end[worker][nimpl];
_STARPU_PTHREAD_MUTEX_UNLOCK(&sched_mutex[worker])


The exact same code can be found in compute_all_performance_predictions() in dmda, except that we do not lock the worker's mutex. Why is that ?





Archives gérées par MHonArc 2.6.19+.

Haut de le page