Re: [Starpu-devel] Scheduler heft

[Samuel Thibault <samuel.thibault@ens-lyon.org>]

Nathalie Furmento, le Wed 21 Nov 2012 10:39:42 +0100, a écrit :
> On 20/11/2012 13:58, Samuel Thibault wrote:
> >Nathalie Furmento, le Tue 20 Nov 2012 09:26:04 +0100, a écrit :
> >>The internal function static int _heft_push_task(struct starpu_task *task,
> >>unsigned prio) does not use the parameter prio in its body. Is it an 
> >>error?
> >It's now all done inside _starpu_fifo_push_task, so the parameter can be
> >got ridden away.
> >
> >>At some point, the task priority it set:
> >>
> >>             task->priority = 0;
> >That's only for the multiformat conversion tasks.  I'm however surprised
> >we reset the priority to zero, I'd rather see the conversion tasks get
> >the same priority.
> 
> Meaning we do not change it? Or we set it to the parameter prio ?

Meaning we *BOTH* do not change it for the original task, and we set
the conversion task prio to the original task priority.  Doing only the
former would break multiformat support.

Samuel