Re: [Starpu-devel] Link a Tag to a task using starpu_insert_task()

[Samuel Thibault <samuel.thibault@ens-lyon.org>]

Samuel Thibault, le Wed 11 Feb 2015 10:15:42 +0100, a écrit :
> > [starpu][starpu_mpi_insert_task][assert failure] STARPU_TAG is not 
> > supported
> > in MPI mode
> 
> Yes, we haven't implemented it yet. It shouldn't be very hard to
> implement it, it's a matter of defining the semantic it is supposed to
> have and not have (no tag dependency between different MPI nodes, at
> least for now).

The "implementation" could be as simple as this patch.  It however
assumes that there is not tag dependency between different MPI nodes,
without testing it.

Samuel
Index: mpi/src/starpu_mpi_task_insert.c
===================================================================
--- mpi/src/starpu_mpi_task_insert.c    (révision 14446)
+++ mpi/src/starpu_mpi_task_insert.c    (copie de travail)
@@ -348,7 +348,7 @@
                /* STARPU_DATA_MODE_ARRAY handled above */
                else if (arg_type==STARPU_TAG)
                {
-                       STARPU_ASSERT_MSG(0, "STARPU_TAG is not supported in 
MPI mode\n");
+                       (void)va_arg(varg_list_copy, starpu_tag_t);
                }
                else if (arg_type==STARPU_HYPERVISOR_TAG)
                {
@@ -487,6 +487,8 @@
                _starpu_mpi_clear_data_after_execution(descrs[i].handle, 
descrs[i].mode, me, do_execute, comm);
        }
 
+       free(descrs);
+
        _STARPU_MPI_LOG_OUT();
        return 0;
 }