Re: [Starpu-devel] [Morse-devel] segfault occurring with starpu 1.2.3 and master branch of chameleon

[Samuel Thibault <samuel.thibault@inria.fr>]

Hello,

Hatem Ltaief, on sam. 24 mars 2018 01:53:39 +0000, wrote:
> I am facing a segfault raised by chameleon runtime_descriptor.c when 
> handling
> MPI tags, due to a bad value returned by the new function
> starpu_mpi_comm_get_attr for fixing the MPI tag issue, introduced in starpu
> 1.2.3.

It was bogus indeed, this was fixed in the 1.2 branch with the attached
patch.

Samuel
commit 8b2268d9750f1594460361ea2961372e0e10d7bb
Author: Samuel Thibault <samuel.thibault@ens-lyon.org>
Date:   Sun Mar 4 18:21:49 2018 +0100

    Fix starpu_mpi_comm_get_attr calling convention for STARPU_MPI_TAG_UB 
according to MPI standard
    
    (cherry picked from commit 9ab3f077e2ca7ffbd38aa9691bffe62f55f8de1f)

diff --git a/mpi/src/starpu_mpi.c b/mpi/src/starpu_mpi.c
index f4494924b..823b72e47 100644
--- a/mpi/src/starpu_mpi.c
+++ b/mpi/src/starpu_mpi.c
@@ -2064,13 +2064,15 @@ int starpu_mpi_wait_for_all(MPI_Comm comm)
        return 0;
 }
 
+static int64_t _starpu_mpi_tag_max = INT_MAX;
+
 int starpu_mpi_comm_get_attr(MPI_Comm comm, int keyval, void *attribute_val, 
int *flag)
 {
        (void) comm;
        if (keyval == STARPU_MPI_TAG_UB)
        {
                *flag = 1;
-               *(int *)attribute_val = INT_MAX;
+               *(int64_t **)attribute_val = &_starpu_mpi_tag_max;
        }
        else
        {