Re: [Starpu-devel] exposing the task color field to starpu-task-insert

[Amani Alonazi <amani.alonazi@kaust.edu.sa>]

Thanks Samuel, 

Please find a patch for exposing the task->color field to task-insert utility attached here. 

Thanks and Bye for now,

A.

On Sun, Jun 24, 2018 at 3:21 PM, Samuel Thibault <samuel.thibault@inria.fr> wrote:

Hello,

Amani Alonazi, le dim. 24 juin 2018 11:37:19 +0300, a ecrit:
> I made few modifications to starpu-1.2.4 in order to expose the task color
> field to starpu-task-insert utility. is there a way to do a pull request to
> this repo:
> [1]https://scm.gforge.inria.fr/anonscm/git/starpu/starpu.git
>
> Or is there an official github repo of starpu?

We do not have pull request possibilities.

But you can simply send your patch to this list, and we will happily
apply it :)

Samuel

---

This message and its contents, including attachments are intended solely for the original recipient. If you are not the intended recipient or have received this message in error, please notify me immediately and delete this message from your computer system. Any unauthorized use or distribution is prohibited. Please consider the environment before printing this email.
diff -Naur starpu-1.2.4/include/starpu_task_util.h starpu-1.2.4-taskcolor/include/starpu_task_util.h
--- starpu-1.2.4/include/starpu_task_util.h	2018-04-12 15:47:26.000000000 +0300
+++ starpu-1.2.4-taskcolor/include/starpu_task_util.h	2018-06-25 10:50:19.496245134 +0300
@@ -61,6 +61,7 @@
 #define STARPU_NAME		 (23<<STARPU_MODE_SHIFT)
 #define STARPU_CL_ARGS		(24<<STARPU_MODE_SHIFT)
 #define STARPU_SHIFTED_MODE_MAX (25<<STARPU_MODE_SHIFT)
+#define STARPU_COLOR            (26<<STARPU_MODE_SHIFT)
 
 struct starpu_task *starpu_task_build(struct starpu_codelet *cl, ...);
 int starpu_task_insert(struct starpu_codelet *cl, ...);
diff -Naur starpu-1.2.4/mpi/src/starpu_mpi_task_insert.c starpu-1.2.4-taskcolor/mpi/src/starpu_mpi_task_insert.c
--- starpu-1.2.4/mpi/src/starpu_mpi_task_insert.c	2018-04-12 15:47:26.000000000 +0300
+++ starpu-1.2.4-taskcolor/mpi/src/starpu_mpi_task_insert.c	2018-06-25 10:56:37.698483415 +0300
@@ -409,6 +409,11 @@
 		{
 			select_node_policy = va_arg(varg_list_copy, int);
 		}
+		else if (arg_type==STARPU_COLOR)
+                {
+                        //task_color  
+                        (void)va_arg(varg_list_copy, int);
+                }
 		else
 		{
 			STARPU_ABORT_MSG("Unrecognized argument %d, did you perhaps forget to end arguments with 0?\n", arg_type);
diff -Naur starpu-1.2.4/src/util/starpu_task_insert_utils.c starpu-1.2.4-taskcolor/src/util/starpu_task_insert_utils.c
--- starpu-1.2.4/src/util/starpu_task_insert_utils.c	2018-04-12 15:47:26.000000000 +0300
+++ starpu-1.2.4-taskcolor/src/util/starpu_task_insert_utils.c	2018-06-25 10:52:35.182177122 +0300
@@ -448,6 +448,11 @@
 		{
 			(void)va_arg(varg_list, int);
 		}
+		else if (arg_type==STARPU_COLOR) //task_color 
+                {
+                        int color_num = va_arg(varg_list, int);
+                        task->color = color_num;
+                }
 		else
 		{
 			STARPU_ABORT_MSG("Unrecognized argument %d, did you perhaps forget to end arguments with 0?\n", arg_type);
@@ -652,6 +657,11 @@
 			arg_i++;
 			(void)arglist[arg_i];
 		}
+		else if (arg_type == STARPU_COLOR) //task_color 
+                {
+                        arg_i++;
+                        task->color = *(int *)arglist[arg_i];
+                }
 		else
 		{
 			STARPU_ABORT_MSG("unknown/unsupported argument %d, did you perhaps forget to end arguments with 0?", arg_type);