CGAL users discussion list

["Laurent Rineau (CGAL/GeometryFactory)" <>]

Le mardi 24 septembre 2013 17:00:29 ax487 a écrit :

> On 03.09.2013 22:34, ax487 wrote:

> > Hello all,

> >

> > I have been working with polygons now for a while and i noticed that

> > there are some inconveniences regarding the removal of vertices of a

> > polygon: If I remove an iterator from a normal C++ container modeling an

> > ordered sequence, then the method returns an iterator pointing to the

> > next element. This should (?) also be true for the container used in the

> > polygon (at least it is in the case of a std::vector or a std::list).

> > The attached patch turns this iterator into a Vertex_iterator which can

> > be used in subsequent operations. This change should be downward

> > compatible, so I hope it is possible to include the patch in CGAL.

> >

> > ax487

>

> *bump*

> Sorry for the inconvenience, but could you give me some feedback here?

 

Hi,

 

You are right to insist. Your patch seems sound. I agree if should be compatible with the existing API.

 

Nobody answered you because the Polygon_2 package is collectively maintained by the whole team of CGAL developers, and nobody in particular. It seems that any of us thought another develop would answer your mail, and nobody did. :-\

 

I will integrate your patch in CGAL. There is no need for paperwork (intellectual property transfer), because the patch is small enough to be integrated without.

 

--

Laurent Rineau, PhD

R&D Engineer at GeometryFactory http://www.geometryfactory.com/

Release Manager of the CGAL Project http://www.cgal.org/