CGAL users discussion list

["Funke, Daniel" <>]

Dear CGAL team,

I stumbled upon an infinite loop in the natural_neighbor_coordinates_2
function.

When running the attached example, I get into an infinite loop at
natural_neighbor_coordinates_vertex_2(). I attached a patch that fixes
the symptom of the problem, but I guess the cause is something else
entirely.

I would appreciate if someone could shed some light on the cause of the
issue.

Best regards
Daniel Funke
--- /usr/include/CGAL/natural_neighbor_coordinates_2.h.bak
+++ /usr/include/CGAL/natural_neighbor_coordinates_2.h.mod
@@ -202,11 +202,11 @@
 	   hit->first->vertex(dt.ccw(hit->second))->point(),
 	   p);
 
-      Face_circulator fc = dt.incident_faces(current, hit->first);
+      Face_circulator fc = dt.incident_faces(current, hit->first), done(fc);
       ++fc;
       vor[1] = dt.dual(fc);
 
-     while(!fc->has_vertex(prev))
+     while(!fc->has_vertex(prev) && fc != done)
        {
 	 ++fc;
 	 vor[2] = dt.dual(fc);

Attachment: testbed.tar.gz
Description: testbed.tar.gz