Subject: CGAL users discussion list
List archive
- From: Manoj Bist <>
- To:
- Subject: Re: [cgal-discuss] optimal_convex_partition_2 produces invalid decomposition
- Date: Wed, 15 Sep 2021 13:23:50 -0700
- Authentication-results: mail3-smtp-sop.national.inria.fr; spf=None ; spf=Pass ; spf=None
- Ironport-hdrordr: A9a23:X1uanqHp3h1YXOCMpLqEj8eALOsnbusQ8zAXPidKKCC9E/b3qynApoV56faZskdyZJhCo7+90de7IU80nKQdieJ6AV7IZmXbUQWTQb1f0Q==
- Ironport-phdr: A9a23:UnVF9x1IFeRerLt5smDOhQMyDhhOgF0UFjAc5pdvsb9SaKPrp82kYBaHo6Q0xwKWFazgqNt8w9LMtK7hXWFSqb2gi1slNKJ2ahkelM8NlBYhCsPWQWfyLfrtcjBoVJ8aDAwt8H60K1VaF9jjbFPOvHKy8SQSGhLiPgZpO+j5AIHfg9qr2+yo/5DffgpEiTq/bLhvMBi4sALdu9UMj4B/MKgx0BzJonVJe+RS22xlIE+Ykgj/6Mmt4pNt6jxctP09+cFOV6X6ZLk4QqdDDDs6KWA15dbkugfFQACS+3YTSGQWkh5PAwjY8BH3W4r6vyXmuuZh3iSRIMv7Rq02Vzu/9admUBDniCkFODA5/m/ZidF+grxHrx+6vRNz35TZbZuJOPZifK7Qe84RS2pbXsZWUixMGoSyYJEJD+oGP+ZTspTwp1oVrRuiGAKhA+bvxSVOhn/x3602yf8uEQDd3Aw8At4Dq3vUrNDvO6cTVeC51rXHzTLGb/5P3zr29YfHfAw7r/6WQbJwbdTeyVMpFw7dklmdtIzrMTOR2+kCrmSW7+VuW+Kxh2M7qAx8vjehytssh4TImI8Y1F/K+yplzIs2JtC2R0B2bN2kHZZNtCyXN417Sd4sTWFvvSY10LwGuZijcSgFyZQn2x7fa+GcfISS/h3jU+ORLS95hHJjYrK/hgy9/VKuyu3mUMS/zVVErjJdn9XSqnwA0wbf58uHR/dn4EutxDmC2xrO5uxFJU05k7fQJYQ7zb4qjJUTtFzOHi/ol0Xyi6+bbkAk9fKp6+Tje7nmvpucO5JthgHwL6gjm8iyDf43MggJWGib9uC826P58ULlR7VKi+U6kqjfsJ/EOcQWvrC1DxNR34o56BuyDy2q3MoFkXQINl5JZROKgozxN1HLOv/4DPO/g1q2kDdswvDLJrjhDY/LLnjEkrftZ61y609HyAov0NxS/J1UCrQbL/LyXk/9rsDXDhg8MwCs2eboFM191p8CWWKIGqKWLKzSvkWM5u42PuaMZZQVtyrgK/g+/P7jlmQ5mF8Yfamxx5QbcnG4HvJ8I0WYe3XgmNkBEX1Z9jc4V/Hg3V2eTSZINTH1RLM5/jh9CYS8DI6FSJrqm62ExC78H5tYYSdNBVmIVHvpbI6ZQOxfVSSJP8VBjjkAALi9V5c6h1bprx7/07MhL+zO+yReu4ikz8lw/+SUlBc88nt/AM2Zlm2MVGpphXhbejktwapDrFxhn1efzbBj0bsfDs1W//oPUwEgNJeawfY9EMH3QguGf9GHTxGtTdyiRD0wVdks2MRdX0EoENqrilXP3jGhHqQOv72NHp09tKzGjFbrIMMo7n/A06tppVg9XoMbMGSggaw5/QnIG9fhnECQlqLsfqMZin2evFyfxHaD6RkLGDV7Vr/ICCh3jq7+otHw50eERLirW+xP2uppzMeDLu5SboSsgwwYFbHsP9PRZ2/3kGC1V07gLlykY4/jemFb1yLYWhFsrg==
The issue has been closed as duplicate. There is a temporary fix in a branch that is 5 years old. Is it possible to merge it to the main branch?
I have tried manually merging it to the main branch but have been unsuccessful.
On Tue, Oct 13, 2020 at 4:38 AM "Sebastien Loriot (GeometryFactory)" <> wrote:
I created the following issue to track the resolution of your bug:
https://github.com/CGAL/cgal/issues/5074
Best regards,
Sebastien.
On 10/1/20 8:37 PM, Manoj Bist ( via cgal-discuss
Mailing List) wrote:
> have attached a testcase that illustrates the issue. Its a cpp file
> that you can compile to reproduce the issue.
>
> Please note that the input is valid. Approximate decomposition works
> correctly. Optimal decomposition fails in CGAL_partition_postcondition.
> /Please do not be confused by the name of CGAL ERROR: precondition
> violation. It is actually failing in the post condition, where in it
> verifies that the decomposition is correct./
>
> 1. I've verified that the input polygon is a simple counter clockwise
> polygon. I have put the following two asserts to ensure this invariant.
>
> assert(CGAL::is_simple_2(polygon.vertices_begin(),
> polygon.vertices_end(), Traits()));
> assert(CGAL::orientation_2(polygon.vertices_begin(),
> polygon.vertices_end(), Traits()) == CGAL::COUNTERCLOCKWISE);
> assert(!hasDuplicatePoints(polygon));
>
> 2. To test the logical correctness for the input polygon, I have also
> done the following.
>
> I've identified a point that is outside the input polygon. A point that
> is outside the input polygon should be outside all the polygons in
> convex decomposition.
>
> Approximate decomposition passes this.
>
> 3. First I run the approximate
> decomposition CGAL::approx_convex_partition_2. It works as expected.
>
> 4. This post condition fails for optimal decomposition.
>
> CGAL_partition_postcondition(
> convex_partition_is_valid_2(polygon.begin(), polygon.end(),
> res.output_so_far_begin(),
> res.output_so_far_end(), traits)
>
>
>
> --
> You are currently subscribed to cgal-discuss.
> To unsubscribe or access the archives, go to
> https://sympa.inria.fr/sympa/info/cgal-discuss
>
--
You are currently subscribed to cgal-discuss.
To unsubscribe or access the archives, go to
https://sympa.inria.fr/sympa/info/cgal-discuss
- Re: [cgal-discuss] optimal_convex_partition_2 produces invalid decomposition, Manoj Bist, 09/15/2021
- Re: [cgal-discuss] optimal_convex_partition_2 produces invalid decomposition, Manoj Bist, 09/17/2021
Archive powered by MHonArc 2.6.19+.