Re: [Starpu-devel] [PATCH] src/sched_policies: add starpu_sched_policies_common.{c, h}, that will contain code that can easily be shared between schedulers.

[Samuel Thibault <samuel.thibault@ens-lyon.org>]

Cyril Roelandt, le Tue 06 Mar 2012 18:31:34 +0100, a écrit :
> With this patch, _heft_push_task is smaller and uses less local variables.
> _starpu_compute_best_fitness() will probably be easily reusable in pheft and
> dmda.

pheft would be hard, as there are also the parallel tasks, where fitness
would have to be very different.

dmda should just be merged with heft. The difference is there just to
choose whether to enable data awareness, priorities, etc. but ideally it
should just be merged into one scheduler, with options to enable or
disable.

> Another way of factorizing this code would have been to pass a function 
> pointer
> to _starpu_compute_best_fitness(), thus allowing every scheduler to define 
> its
> own way of computer the fitness metric for a given worker, but it would have
> added lots of function calls.

And would be quite hairy for not so much profit.

> Plus, it seems to me that the fitness is always computed the same way,
> so this is not really necessary.

Well, that's already not true for pheft.

Samuel