Re: [Starpu-devel] [PATCH] src/sched_policies: add starpu_sched_policies_common.{c, h}, that will contain code that can easily be shared between schedulers.

[Samuel Thibault <samuel.thibault@ens-lyon.org>]

Cyril Roelandt, le Tue 06 Mar 2012 18:51:32 +0100, a écrit :
> On 03/06/2012 06:36 PM, Samuel Thibault wrote:
> >Cyril Roelandt, le Tue 06 Mar 2012 18:31:34 +0100, a écrit :
> >>With this patch, _heft_push_task is smaller and uses less local variables.
> >>_starpu_compute_best_fitness() will probably be easily reusable in pheft 
> >>and
> >>dmda.
> >
> >pheft would be hard, as there are also the parallel tasks, where fitness
> >would have to be very different.
> >
> >dmda should just be merged with heft. The difference is there just to
> >choose whether to enable data awareness, priorities, etc. but ideally it
> >should just be merged into one scheduler, with options to enable or
> >disable.
> >
> 
> So, rather than trying to factorize parts of the code, should we :
> 
> 1) Clean up heft (basically, get rid of the endless functions that use a
> gazillion parameters and local variables).
> 
> 2) Make sure heft can do dmda's job, adding options etc.
> 
> 3) Once it's all been tested, remove dmda.
> 
> ?

Or the converse, depending on what we prefer.  Andra will however
probably want to merge her context work before that (actually that's the
reason we do such factorization in the past months).

Samuel