Re: [Starpu-devel] Merge of sched_ctx branch into the trunk

[Nathalie Furmento <nathalie.furmento@labri.fr>]

Andra,

I would say we merge now. The things on the todo list can be dealt with 
after the merge.

The only thing is to be sure that some code has not been lost by the 
merge. Andra, did you look at the files which are not supposed to differ 
between the trunk and the sched_cxt branch ?

As soon as that problem is solved, we merge.

Cheers,

Nathalie

On 07/12/2012 10:17, Andra Hugo wrote:
> Hi,
>
> Exactly, there's a huge todo list, and instead of doing this i spend all my 
> time doing merges every 2 hours.
>
> I have some doubts that someone will ever help me fixing things as long as I 
> keep my work on a branch.
>
>
> Andra
>
> ----- Mail original -----
> > De: "Cyril Roelandt"<cyril.roelandt@inria.fr>
> > À: "Andra Hugo"<andra.hugo@inria.fr>
> > Cc: starpu-devel@lists.gforge.inria.fr
> > Envoyé: Vendredi 7 Décembre 2012 03:59:20
> > Objet: Re: [Starpu-devel] Merge of sched_ctx branch into the  trunk
> >
> > On 12/06/2012 02:18 PM, Andra Hugo wrote:
> > > Hello,
> > Hi!
> >
> > > I would like to finally merge the sched_ctx branch into the trunk.
> > > I've done the last merge of the trunk into the branch 2h ago and
> > > hydra tests seem good.
> > >
> > > Is everyone ok with it?
> > A few things are still bugging me.
> >
> > - there is a *huge* TODO list at
> > https://wiki.bordeaux.inria.fr/runtime/doku.php?id=starpu_sched_ctx .
> > What about it?
> >
> > - hydra isn't really happy: there are more failures in sched_ctx than
> > in
> > the trunk.
> >
> > - scan-build is not happy either. Last time I checked, it found a
> > possible NULL-pointer dereference, for instance.
> >
> > - there are style issues. We cleaned the code as much as possible for
> > 1.0, so I'd like it to stay as clean as possible.
> >
> >
> >
> > I've just tried to compile your branch, and it fails with a bunch of
> > errors (undefined references to cublas, cuda and pthread functions).
> >
> > This error:
> > http://hydra.bordeaux.inria.fr/build/127928/download/1/nix-build-b2b358r4bss942v5xjvzb672r30jgbq7-starpu-0.drv-0/starpu-1.1.0/tests/parallel_tasks/parallel_kernels.log
> >
> > probably has something to due with the incomplete switch in
> > _starpu_can_use_nth_implementation().
> >
> > We're almost there, though :) Keep up the good work! I'd be happy to
> > help you as much as I can (given the limited amount of time I have
> > :p).
> >
> > Cyril Roelandt.
> _______________________________________________
> Starpu-devel mailing list
> Starpu-devel@lists.gforge.inria.fr
> http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/starpu-devel