Re: [Starpu-devel] [PATCH] examples audio fix

[Samuel Thibault <samuel.thibault@inria.fr>]

Hello,

Francisco Alecrim, on ven. 16 juin 2017 02:52:29 +0000, wrote:
>     > and use CFLAGS variable on Makefile.
> 
>     I didn't see that part in the patch?
> 
> LDFLAGS was empty for me.

Well, this is not really a problem, it just means there is nothing
needed for it.

> diff --git a/examples/audio/Makefile b/examples/audio/Makefile
> index 8019697..37ce6bf 100644
> --- a/examples/audio/Makefile
> +++ b/examples/audio/Makefile
> @@ -27,7 +27,7 @@ all: starpu_audio_processing
>  starpu_audio_processing.o: starpu_audio_processing.c
>  
>  starpu_audio_processing: starpu_audio_processing.o
> -       $(CC) $(LDFLAGS) starpu_audio_processing.o -o 
> starpu_audio_processing $
> (LIBS)
> +       $(CC) $(CFLAGS) starpu_audio_processing.o -o 
> starpu_audio_processing $
> (LIBS)

But CFLAGS are meant for the build of starpu_audio_processing.o, not the
link. And make already includes CFLAGS when building .o files, this is
implicit.  So I do not see what this change fixes, I'd need to see the
actual complete output of the broken make situation.

Samuel