Re: [Starpu-devel] setting the clBuildProgram() option parameter

[Cédric Augonnet <cedric.augonnet@inria.fr>]

Hi,

Nathalie, I see that according to the doc: -cl-mad-enable "Allow a * b + c to be replaced by a mad. The mad computes a * b + c with reduced accuracy". I guess we don't want that in the general case either... Otherwise this all looks good, thanks a lot! Just being picky: if we really want to enforce -Werror, can't we append the user-provided string with -Werror for instance?

Best,
Cédric

On 05/04/2011 07:20, Jonathan Adamczewski wrote:

4D9AA693.8040900@utas.edu.au">Thank you - that works well.

j.

On 05/04/11 07:27, Nathalie Furmento wrote:

All,

I updated the OpenCL kernel to provide an extra parameter
build_options to the appropriate functions. A NULL value will fall
back on the default value"-Werror -cl-mad-enable".

Best,

Nathalie

On 04/04/2011 19:01, Cédric Augonnet wrote:

On 04/04/2011 17:39, Jonathan Adamczewski wrote:

clBuildProgram() is called within
starpu_opencl_load_opencl_from_string() with a hard-coded
options parameter of "-Werror -cl-mad-enable". I would like to
be able to set different options, such as include paths and
macro definitions for the opencl kernels I am using with starpu.

If I were to add support for different option strings, what
would be an appropriate/preferred way to do so? Options I can
see are:
 - extra parameter passed to the function (which needs to be
added to other functions, too)
 - extra const char* field in struct starpu_opencl_program (one
option for all opencl programs)
 - array of const char* fields in struct starpu_opencl_program,
one for each program
 - environment variable

Thanks

Jonathan.

Hi Jonathan,

Thanks again for your valuable feedback! Would not an extra
"const char *" parameter to both
starpu_opencl_load_opencl_from_file and
starpu_opencl_load_opencl_from_string be sufficient ? This seems
to be the most natural and also the cleanest solution.

Best,
Cédric

_______________________________________________
Starpu-devel mailing list
Starpu-devel@lists.gforge.inria.fr
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/starpu-devel

_______________________________________________
Starpu-devel mailing list
Starpu-devel@lists.gforge.inria.fr
http://lists.gforge.inria.fr/cgi-bin/mailman/listinfo/starpu-devel