CGAL users discussion list

[Camille Wormser <>]

Andreas Fabri a écrit :
> Note that it is a feature not a bug to not compute the plane.
I know, now... I just disagree with the idea that this feature does more 
good than harm.

> So please don't hastily commit it to svn, but first discuss it
> on the developer mailing list.
I don't think this patch should be integrated "as is" anyway: I 
hardcoded the way of selecting the vertices used to compute the 
supporting hyperplane.

> Note that the tag is a tag and not a variable which can change
> the state at runtime, 
I know that, but setting this flag creates an uninitialized data member 
in the structure, and this is the default.

> and it has "Supports" in the name, and
> not "Computes".
Just like HalfedgeDSFace::Supports_face_halfedge or any other Supports_* 
flag... which all provide you _initialized_ data members...

> I guess what we might do is to add a boolean variable to the polyhedron
> class or the face class that is true if the plane is computed, and when
> one wants to access it, one checks the flag.
I think that this is exactly the purpose of the Supports_face_plane 
flag. If someone just wants to compute _some_ of the planes, then there 
is no reason to have an ad hoc method to deal with it, and CGAL could 
provide a HalfedgeDS_face_base_with_info instead.

Best,
--
Camille